Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add missing eslint directive comments in no-await-in-loop #13673

Merged
merged 1 commit into from Sep 10, 2020

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Sep 8, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

This PR adds missing eslint directive comments to correct and incorrect examples for the no-await-in-loop rule.

What changes did you make? (Give an overview)

Added /*eslint no-await-in-loop: "error"*/ to no-await-in-loop examples.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added rule documentation accepted labels Sep 8, 2020
@mdjermanovic mdjermanovic merged commit 5138c91 into master Sep 10, 2020
12 checks passed
@mdjermanovic mdjermanovic deleted the noawaitinloop-eslintcomments branch Sep 10, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age documentation rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants