Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: support async arrow fn in function-paren-newline (fixes #13728) #13729

Merged
merged 1 commit into from Oct 6, 2020

Conversation

mdziekon
Copy link
Contributor

@mdziekon mdziekon commented Oct 1, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Bug fix (fixes #13728)

What changes did you make? (Give an overview)

Added support for the async ArrowFunctionExpression in function-paren-newline. This fixes the issue where source analysis for this node type wrongly assumes that it does not have an opening parenthesis (because it thinks that in this case, opening paren is always the first token, which since ES2017 is no longer a guarantee).

Is there anything you'd like reviewers to focus on?

No

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 1, 2020
@eslint-deprecated
Copy link

@eslint-deprecated eslint-deprecated bot commented Oct 1, 2020

Hi @mdziekon!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Oct 2, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

@mdziekon thanks for finding and fixing this bug!

The code and very comprehensive tests look great.

I have just a small request about the commit message. Since this is a bug fix that can produce more warnings, the commit message should start with Update: instead of Fix: (this is important for our semver policy).

The message could be something like this:

Update: support async arrow fn in function-paren-newline (fixes #13728)

@mdziekon
Copy link
Contributor Author

@mdziekon mdziekon commented Oct 2, 2020

@mdjermanovic sure thing, I've pushed an amended commit message.

@mdziekon mdziekon requested a review from mdjermanovic Oct 2, 2020
@mdjermanovic mdjermanovic changed the title Fix: support async arrow functions in function-paren-newline Update: support async arrow fn in function-paren-newline (fixes #13728) Oct 2, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Member

@yeonjuan yeonjuan left a comment

LTGM! Thanks

@mdjermanovic mdjermanovic merged commit da78fa1 into eslint:master Oct 6, 2020
12 checks passed
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 6, 2020

Thanks for contributing!

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 5, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants