Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: account for linebreaks before postfix ++/-- in no-extra-parens #13731

Merged
merged 1 commit into from Oct 6, 2020

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 2, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Tell us about your environment

  • ESLint Version: v7.10.0
  • Node Version: v12.18.4
  • npm Version: v6.14.6

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015
  }
};

What did you do? Please include the actual source code causing the issue.

Online Demo

/* eslint no-extra-parens: "error" */

(a
)++

What did you expect to happen?

No errors. Per the specification for UpdateExpression, linebreaks are not allowed before postfix ++ and --. In similar situations (return, throw, yield) no-extra-parens doesn't report an error.

What actually happened? Please include the actual, raw output from ESLint.

no-extra-parens error and auto-fix to:

/* eslint no-extra-parens: "error" */

a
++

Message after the auto-fix:

  5:1  error  Parsing error: Unexpected token

What changes did you make? (Give an overview)

Fixed the no-extra-parens rule to not report an error if the parenthesized argument of an UpdateExpression is not on the same line as the postfix operator.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug rule accepted labels Oct 2, 2020
Copy link
Member

@yeonjuan yeonjuan left a comment

LGTM!

@mdjermanovic mdjermanovic merged commit 27f0de6 into master Oct 6, 2020
12 checks passed
@mdjermanovic mdjermanovic deleted the noextraparens-postfixupdate branch Oct 6, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 5, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age bug rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants