Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove more ESLintRC-related files (refs #13481) #13762

Merged
merged 8 commits into from Oct 23, 2020
Merged

Conversation

@nzakas
Copy link
Member

@nzakas nzakas commented Oct 16, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

As part of #13481, I've refactored tests to avoid using the in-memory filesystem helper.

What changes did you make? (Give an overview)

Changed tests for CLIEngine, ESLint, and FileEnumerator to use an actual filesystem instead of an in-memory one. Also removed CascadingConfigArrayFactory and ConfigArrayFactory as these are now included from @eslint/eslintrc.

I didn't remove the in-memory filesystem utility because it is still in use by some other tests.

Is there anything you'd like reviewers to focus on?

Did I miss any related functionality?

@eslint
Copy link
Contributor

@eslint eslint bot commented Oct 16, 2020

Hi @nzakas!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@eslint
Copy link
Contributor

@eslint eslint bot commented Oct 16, 2020

Hi @nzakas!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@nzakas nzakas marked this pull request as draft Oct 16, 2020
@nzakas
Copy link
Member Author

@nzakas nzakas commented Oct 16, 2020

Apologies, I thought this was ready but then the last step seemed to mess everything up. I'll continue working.

@eslint
Copy link
Contributor

@eslint eslint bot commented Oct 16, 2020

Hi @nzakas!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@eslint
Copy link
Contributor

@eslint eslint bot commented Oct 16, 2020

Hi @nzakas!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@mdjermanovic mdjermanovic changed the title Chore: Remove more ESLintRC-related files (refs #13481) Chore: Remove more ESLintRC-related files (refs #13481) Oct 16, 2020
@eslint
Copy link
Contributor

@eslint eslint bot commented Oct 16, 2020

Hi @nzakas!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The issue reference must be formatted as follows:

    If the pull request addresses an issue, then the issue number should be mentioned at the end. If the commit doesn't completely fix the issue, then use (refs #1234) instead of (fixes #1234).

    Here are some good commit message summary examples:

    Build: Update Travis to only test Node 0.10 (refs #734)
    Fix: Semi rule incorrectly flagging extra semicolon (fixes #840)
    Upgrade: Esprima to 1.2, switch to using comment attachment (fixes #730)
    

Read more about contributing to ESLint here

@mdjermanovic mdjermanovic changed the title Chore: Remove more ESLintRC-related files (refs #13481) Chore: Remove more ESLintRC-related files (refs #13481) Oct 16, 2020
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 16, 2020

Removed leading and trailing spaces from the title.

@nzakas nzakas marked this pull request as ready for review Oct 19, 2020
@nzakas
Copy link
Member Author

@nzakas nzakas commented Oct 19, 2020

I had to adjust the coverage settings across all four dimensions to get this to pass, but I think it's worth it.

Copy link
Member

@btmills btmills left a comment

I underestimated just how much code extracting eslintrc would remove from core.

tests/lib/eslint/eslint.js Outdated Show resolved Hide resolved
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
Copy link
Member

@btmills btmills left a comment

LGTM. Merging this into today's release so you can keep working.

@btmills btmills merged commit 1a9f171 into master Oct 23, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@btmills btmills deleted the simple-config-step-3 branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.