Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Chore: Increase Mocha timeout for copying fixtures #13768
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
What changes did you make? (Give an overview)
For the last several weeks, our CI jobs have been flaky due to test hook timeouts on the Windows and macOS runners. I traced most of the failures to four
Is there anything you'd like reviewers to focus on?
For the last several weeks, our CI jobs have been flaky due to test hook timeouts on the Windows and macOS runners. I traced most of the failures to four `before` hooks that copy the test fixtures to a temporary directory. They usually take ~2.5s, but that occasionally spikes to tens of seconds: in the two times I was able to repro the timeouts, the slowest copy jobs were 25 and 32 seconds. Rather than increasing the global test timeout, I instead bumped it just for these four hooks that were causing problems.