Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix the format option name in the document #13770

Merged
merged 1 commit into from Oct 20, 2020

Conversation

@ganta
Copy link
Contributor

@ganta ganta commented Oct 18, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The correct name of the option to specify the output format is --format, but it was described as --formatter, so it has been fixed.

Is there anything you'd like reviewers to focus on?

Nothing. This is a tiny contribution.

@eslint eslint bot added the triage label Oct 18, 2020
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 18, 2020

Good catch, thanks for the PR!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Member

@yeonjuan yeonjuan left a comment

LGTM! Thanks 👍

@mdjermanovic mdjermanovic merged commit b025795 into eslint:master Oct 20, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 20, 2020

Thanks for contributing!

@ganta ganta deleted the ganta:fix-format-option-name-in-document branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.