Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: check template literal in no-script-url #13775

Merged
merged 5 commits into from Oct 23, 2020
Merged

Conversation

@yeonjuan
Copy link
Member

@yeonjuan yeonjuan commented Oct 20, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Add template literal checking in no-script-url. :)

Is there anything you'd like reviewers to focus on?

no

@eslint eslint bot added the triage label Oct 20, 2020
@yeonjuan yeonjuan added accepted bug rule and removed triage labels Oct 20, 2020
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 20, 2020

I support treating this as a bug.

Similar changes in other rules were accepted as semver-minor bug fixes:

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Left two questions, and I think we should change the commit message (or just PR title if there will be additional commits) to Update: :)

lib/rules/no-script-url.js Show resolved Hide resolved
lib/rules/no-script-url.js Outdated Show resolved Hide resolved
@yeonjuan yeonjuan changed the title Fix: check template literal in no-script-url Update: check template literal in no-script-url Oct 21, 2020
@yeonjuan
Copy link
Member Author

@yeonjuan yeonjuan commented Oct 21, 2020

Left two questions, and I think we should change the commit message (or just PR title if there will be additional commits) to Update: :)

@mdjermanovic Sure :) I changed it. Thanks for the review

lib/rules/no-script-url.js Outdated Show resolved Hide resolved
lib/rules/no-script-url.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Member

@btmills btmills left a comment

LGTM, thanks @yeonjuan! And thanks @mdjermanovic for linking precedent for treating this like a bug previously.

@btmills btmills merged commit 5183b14 into master Oct 23, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@btmills btmills deleted the temp-literal-no-script-url branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.