Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: @eslint/eslintrc to fix rule schema validation (fixes #13793) #13794

Merged
merged 2 commits into from Oct 27, 2020

Conversation

@btmills
Copy link
Member

@btmills btmills commented Oct 26, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The bulk of our tests for rule schemas are isolated unit tests of ConfigValidator. This is a single test to be sure we actually run rule schema validation end-to-end and prevent cases like #13793.

Is there anything you'd like reviewers to focus on?

Here's my checklist for the patch release tomorrow. Am I missing anything?

  • Merge eslint/eslintrc#14.
  • Run a patch release of @eslint/eslintrc.
  • Push a commit to this branch to bump the @eslint/eslintrc dependency to v0.2.1.
  • Remove the "blocked" label.
  • Rename the pull request to title to "Fix" and "fixes".
  • Merge this.
  • Merge any other patch release fixes.
  • Run a patch release of eslint.
The bulk of our tests for rule schemas are isolated unit tests of
`ConfigValidator`. This is a single test to be sure we actually run rule
schema validation end-to-end and prevent cases like #13793.

After I run a patch release of `@eslint/eslintrc`, I'll push a second
commit on this branch to bump the dependency version and fix the test.
Copy link
Member

@mdjermanovic mdjermanovic left a comment

The test and the plan LGTM!

@btmills btmills removed the blocked label Oct 27, 2020
@btmills btmills changed the title Chore: Test missing built-in rule validation (refs #13793) Upgrade: @eslint/eslintrc to fix rule schema validation (fixes #13793) Oct 27, 2020
@btmills btmills merged commit 08f33e8 into master Oct 27, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
@btmills btmills deleted the issue13793 branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.