Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove eslint comment from no-octal-escape tests #13846

merged 1 commit into from Nov 19, 2020


Copy link

@mdjermanovic mdjermanovic commented Nov 15, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Removes /* eslint no-octal-escape: 0 */ comment from the no-octal-escape test file.

I believe this was added when some tests mistakenly had octal escapes directly in code strings, instead of producing code with octal escapes (e.g., "'\1'" instead of "'\\1'").

What changes did you make? (Give an overview)

Removed the comment.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic merged commit 95d2fe6 into master Nov 19, 2020
12 checks passed
@mdjermanovic mdjermanovic deleted the nooctalescape-eslintcomment branch Nov 19, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants