Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: no-restricted-imports is only for static imports #13863

Merged
merged 1 commit into from Nov 18, 2020

Conversation

@robatwilliams
Copy link
Contributor

@robatwilliams robatwilliams commented Nov 18, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Mentioned that it doesn't work for dynamic imports, as currently a reader might expect that it does. Following #13594, which was closed due to lack of consensus.

Is there anything you'd like reviewers to focus on?

No.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks for the PR!

Loading

@mdjermanovic mdjermanovic merged commit eda0aa1 into eslint:master Nov 18, 2020
13 checks passed
Loading
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Nov 18, 2020

Thanks for contributing!

Loading

@robatwilliams robatwilliams deleted the patch-1 branch Nov 18, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants