Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: file-entry-cache@6.0.0 #13877

Merged
merged 1 commit into from Dec 5, 2020
Merged

Conversation

@realityking
Copy link
Contributor

@realityking realityking commented Nov 24, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: upgrading file-entry-cache to version 6. This drops the indirect dependency on write. See royriojas/flat-cache#49

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Nov 24, 2020

Thanks for the PR!

Is required Node version the only breaking change in file-entry-cache@6.0.0?

Loading

@realityking
Copy link
Contributor Author

@realityking realityking commented Nov 24, 2020

Yes it is. And it was explicitly aligned to that of eslint.

Loading

btmills
btmills approved these changes Dec 5, 2020
Copy link
Member

@btmills btmills left a comment

LGTM. Thanks for going out of your way to align the supported versions!

Marking as "accepted" after mdjermanovic and nzakas mentioned this as good to go in today's release discussion.

Loading

@btmills btmills merged commit 0eb7957 into eslint:master Dec 5, 2020
13 checks passed
Loading
@realityking realityking deleted the file-entry-cache branch Dec 5, 2020
@realityking
Copy link
Contributor Author

@realityking realityking commented Dec 11, 2020

The thanks for aligning with eslint version should go to @royriojas who made it happen :)

Loading

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants