Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: false positive with await and ** in no-extra-parens (fixes #12739) #13923

Merged
merged 1 commit into from Dec 18, 2020

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Dec 12, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #12739

What changes did you make? (Give an overview)

Changed the no-extra-parens rule to not report parens around await if it's LHS of **:

async function f() {
    (await a) ** b // this was a false positive
} 

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug rule accepted labels Dec 12, 2020
@mdjermanovic mdjermanovic merged commit 555c128 into master Dec 18, 2020
13 checks passed
@mdjermanovic mdjermanovic deleted the issue12739 branch Dec 18, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 17, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age bug rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants