Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: space-in-parens examples with no arguments etc. #13987

Merged
merged 1 commit into from Jan 10, 2021

Conversation

brodybits
Copy link
Contributor

@brodybits brodybits commented Jan 5, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

add examples such as foo( ) & foo(/* bar */)

What changes did you make? (Give an overview)

Add incorrect & correct examples for space-in-parens:

  • foo( )
  • foo(/* bar */)
  • foo( /* bar */ )

related to: PR #13986 - test foo( ) with space-in-parens: ["error", "always"]

Is there anything you'd like reviewers to focus on?

see above

@eslint-deprecated eslint-deprecated bot added the triage label Jan 5, 2021
@mdjermanovic mdjermanovic added accepted documentation rule and removed triage labels Jan 6, 2021
@mdjermanovic
Copy link
Member

mdjermanovic commented Jan 6, 2021

Thanks for the PR! I think the added examples are very useful to further clarify the behavior with empty parens, and also clarify that parens with comments inside are not treated as empty parens.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Member

@btmills btmills left a comment

LGTM, thanks for improving the docs!

@btmills btmills merged commit 4a38bbe into eslint:master Jan 10, 2021
13 checks passed
@brodybits brodybits deleted the patch-2 branch Feb 1, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jul 10, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age documentation rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants