Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Explain why we disable lock files (refs eslint/tsc-meetings#234) #14006

Merged
merged 1 commit into from Jan 18, 2021

Conversation

@btmills
Copy link
Member

@btmills btmills commented Jan 15, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Following up on today's TSC meeting, this documents why we chose to disable package-lock.json.

Is there anything you'd like reviewers to focus on?

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Looks good to me!

I'll leave this open if anyone else would like to review before merging.

Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM! 💯

@aladdin-add aladdin-add merged commit f7ca481 into master Jan 18, 2021
13 checks passed
13 checks passed
@github-actions
Verify Files
Details
@github-actions
Test (ubuntu-latest, 15.x)
Details
@github-actions
Test (ubuntu-latest, 14.x)
Details
@github-actions
Test (ubuntu-latest, 13.x)
Details
@github-actions
Test (ubuntu-latest, 12.x)
Details
@github-actions
Test (ubuntu-latest, 10.x)
Details
@github-actions
Test (ubuntu-latest, 10.12.0)
Details
@github-actions
Test (windows-latest, 12.x)
Details
@github-actions
Test (macOS-latest, 12.x)
Details
@github-actions
Browser Test
Details
@eslint-deprecated
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
@eslint-deprecated
release-monitor This change is semver-patch
Details
@aladdin-add aladdin-add deleted the docs-lockfile branch Jan 18, 2021
This was referenced Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants