Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: fix no-invalid-regexp false negatives with no flags specified #14018

Merged
merged 1 commit into from Jan 26, 2021

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Jan 20, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Tell us about your environment

  • ESLint Version: v7.18.0
  • Node Version: v12.18.4
  • npm Version: 6.14.6

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015
  }
};

What did you do? Please include the actual source code causing the issue.

Online Demo

/* eslint no-invalid-regexp: error */

new RegExp("\\u{0}*");

new RegExp("\\u{0}*", "");

What did you expect to happen?

2 errors

These regular expressions would be valid with the u flag, but it isn't specified.

What actually happened? Please include the actual, raw output from ESLint.

no errors

What changes did you make? (Give an overview)

Fixed the no-invalid-regexp rule to distinguish cases where the flags are not specified, so it is known that the regex does not have the u flag, from cases where the flags are unknown so the rule reports an error only if the pattern is invalid both with and without the u flag.

Is there anything you'd like reviewers to focus on?

Copy link
Member

@aladdin-add aladdin-add left a comment

lgtm! 💯

@nzakas
nzakas approved these changes Jan 26, 2021
@nzakas nzakas merged commit 1c309eb into master Jan 26, 2021
13 checks passed
13 checks passed
@github-actions
Verify Files
Details
@github-actions
Test (ubuntu-latest, 15.x)
Details
@github-actions
Test (ubuntu-latest, 14.x)
Details
@github-actions
Test (ubuntu-latest, 13.x)
Details
@github-actions
Test (ubuntu-latest, 12.x)
Details
@github-actions
Test (ubuntu-latest, 10.x)
Details
@github-actions
Test (ubuntu-latest, 10.12.0)
Details
@github-actions
Test (windows-latest, 12.x)
Details
@github-actions
Test (macOS-latest, 12.x)
Details
@github-actions
Browser Test
Details
@eslint-deprecated
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
@eslint-deprecated
release-monitor No patch release is pending
Details
@nzakas nzakas deleted the noinvalidregexp-uflagfix branch Jan 26, 2021
This was referenced Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants