Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: fix comma-dangle schema (fixes #13739) #14030

Merged
merged 1 commit into from Aug 5, 2021

Conversation

mrlorentx
Copy link
Contributor

@mrlorentx mrlorentx commented Jan 23, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #13739

What changes did you make? (Give an overview)

Added additionalItems: false in order to allow specifying only 1 option.

Is there anything you'd like reviewers to focus on?

Please see #13166 for discussions regarding semver handling on this (breaking) change. A revert was made on the accepted PR, so this fix is pending a new major release

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 23, 2021
@eslint-deprecated
Copy link

eslint-deprecated bot commented Jan 23, 2021

Hi @JoakimoNilsson!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@eslint-deprecated
Copy link

eslint-deprecated bot commented Jan 23, 2021

Hi @JoakimoNilsson!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

@eslint-deprecated
Copy link

eslint-deprecated bot commented Jan 23, 2021

Hi @JoakimoNilsson!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The issue reference must be formatted as follows:

    If the pull request addresses an issue, then the issue number should be mentioned at the end. If the commit doesn't completely fix the issue, then use (refs #1234) instead of (fixes #1234).

    Here are some good commit message summary examples:

    Build: Update Travis to only test Node 0.10 (refs #734)
    Fix: Semi rule incorrectly flagging extra semicolon (fixes #840)
    Upgrade: Esprima to 1.2, switch to using comment attachment (fixes #730)
    

Read more about contributing to ESLint here

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jan 23, 2021
@mdjermanovic mdjermanovic marked this pull request as draft Jan 23, 2021
@mdjermanovic
Copy link
Member

mdjermanovic commented Jan 23, 2021

Hi @JoakimoNilsson, thanks for the PR!

I converted this to draft to avoid accidental merging, as it's a breaking change so we'll wait for the next major release.

@mrlorentx
Copy link
Contributor Author

mrlorentx commented Jan 24, 2021

Thank you @mdjermanovic! If there's anything I can do don't hesitate to ask!

@mdjermanovic mdjermanovic marked this pull request as ready for review Jun 11, 2021
@mdjermanovic mdjermanovic changed the title Disallow multiple option types in comma-dangle schema (fixes #13739) Breaking: fix comma-dangle schema (fixes #13739) Jun 11, 2021
@mdjermanovic
Copy link
Member

mdjermanovic commented Jun 11, 2021

@JoakimoNilsson the change looks good!

Could you please update the commit message to start with Breaking:?

It can be like the current PR title: Breaking: fix comma-dangle schema (fixes #13739)

Alternatively, we could change the commit message on merge.

@nzakas
Copy link
Member

nzakas commented Jun 17, 2021

Let's just update on merge.

nzakas
nzakas approved these changes Jun 17, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM

@nzakas nzakas merged commit 8b4f3ab into eslint:master Aug 5, 2021
3 checks passed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 2, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix comma-dangle schema
4 participants