Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add a correct example to no-unsafe-optional-chaining (refs #14029) #14050

Merged
merged 1 commit into from Jan 29, 2021

Conversation

@arminyahya
Copy link
Contributor

@arminyahya arminyahya commented Jan 28, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

I added obj.foo?.bar as a correct example for this rule,
since it's probably the most common usage of optional chaining.

Is there anything you'd like reviewers to focus on?

No.

#14029

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks for contributing!

@mdjermanovic mdjermanovic merged commit e0b05c7 into eslint:master Jan 29, 2021
13 checks passed
@arminyahya arminyahya deleted the issue14029 branch Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants