Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update max-lines.md

Merged
merged 1 commit into from Apr 5, 2021
Merged

Docs: Update max-lines.md #14273

merged 1 commit into from Apr 5, 2021

Conversation

Shinigami92
Copy link
Contributor

@Shinigami92 Shinigami92 commented Mar 30, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage label Mar 30, 2021
@eslint-github-bot
Copy link

eslint-github-bot bot commented Mar 30, 2021

Hi @Shinigami92!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@Shinigami92 Shinigami92 changed the title Update max-lines.md Docs: Update max-lines.md Mar 30, 2021
@eslint-github-bot
Copy link

eslint-github-bot bot commented Mar 30, 2021

Hi @Shinigami92!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@mdjermanovic mdjermanovic added documentation rule and removed triage labels Mar 31, 2021
docs/rules/max-lines.md Show resolved Hide resolved
@mdjermanovic
Copy link
Member

mdjermanovic commented Apr 4, 2021

Can you please sign our CLA, so we could merge this?

@Shinigami92
Copy link
Contributor Author

Shinigami92 commented Apr 4, 2021

Done

@mdjermanovic mdjermanovic added the accepted label Apr 5, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 0d6235e into eslint:master Apr 5, 2021
12 of 13 checks passed
@mdjermanovic
Copy link
Member

mdjermanovic commented Apr 5, 2021

Thanks for contributing!

@Shinigami92 Shinigami92 deleted the patch-1 branch Apr 5, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 3, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age documentation rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants