Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Drop codeframe and table formatters #14316

Merged
merged 8 commits into from Aug 5, 2021
Merged

Conversation

@fregante
Copy link
Contributor

@fregante fregante commented Apr 12, 2021

Fixes #14277
Related to #14098

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Removal of features. Breaking

What changes did you make? (Give an overview)

I dropped the table and codeframe formatters from the core as discussed in #14277

Is there anything you'd like reviewers to focus on?

Easy upgrades FTW
@fregante fregante marked this pull request as ready for review Apr 12, 2021
@fregante fregante mentioned this pull request Apr 12, 2021
1 task
lib/cli-engine/cli-engine.js Outdated Show resolved Hide resolved
@bl-ue
Copy link

@bl-ue bl-ue commented May 25, 2021

ping @fregante — any progress? Would be cool to get this merged 😎

@fregante
Copy link
Contributor Author

@fregante fregante commented Jun 3, 2021

Sorry for the delay!

tests/lib/cli-engine/cli-engine.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

@fregante can you fix #14316 (comment), and rebase (there's a conflict in package.json)?

Everything else LGTM

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM

nzakas
nzakas approved these changes Jun 17, 2021
@TimvdLippe
Copy link
Contributor

@TimvdLippe TimvdLippe commented Jul 30, 2021

I see that the 8.0.0 milestone has been created, excited for that! Can we add this PR to the milestone as well? Thanks!

@nzakas
Copy link
Member

@nzakas nzakas commented Jul 30, 2021

Only issues are in v8.0.0 board. This PR is there by virtue of the linked issue.

@TimvdLippe
Copy link
Contributor

@TimvdLippe TimvdLippe commented Jul 30, 2021

Ah of course. Sorry for the noise!

fregante added a commit to fregante/eslint-formatter-table that referenced this issue Aug 3, 2021
@fregante
Copy link
Contributor Author

@fregante fregante commented Aug 3, 2021

If anyone wants to maintain these 2 formatters, let me know, they're available as standalone projects:

Please advertise them in your post because I won't be maintaining them.

@nzakas nzakas merged commit 86bb63b into eslint:master Aug 5, 2021
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants