Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Drop codeframe and table formatters #14316

Merged
merged 8 commits into from Aug 5, 2021
Merged

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Apr 12, 2021

Fixes #14277
Related to #14098

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Removal of features. Breaking

What changes did you make? (Give an overview)

I dropped the table and codeframe formatters from the core as discussed in #14277

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Apr 12, 2021
Easy upgrades FTW
@fregante fregante marked this pull request as ready for review Apr 12, 2021
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features and removed triage An ESLint team member will look at this issue soon labels Apr 12, 2021
lib/cli-engine/cli-engine.js Outdated Show resolved Hide resolved
@bl-ue
Copy link

bl-ue commented May 25, 2021

ping @fregante — any progress? Would be cool to get this merged 😎

@fregante
Copy link
Contributor Author

fregante commented Jun 3, 2021

Sorry for the delay!

tests/lib/cli-engine/cli-engine.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

@fregante can you fix #14316 (comment), and rebase (there's a conflict in package.json)?

Everything else LGTM

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM

nzakas
nzakas approved these changes Jun 17, 2021
@TimvdLippe
Copy link
Contributor

TimvdLippe commented Jul 30, 2021

I see that the 8.0.0 milestone has been created, excited for that! Can we add this PR to the milestone as well? Thanks!

@nzakas
Copy link
Member

nzakas commented Jul 30, 2021

Only issues are in v8.0.0 board. This PR is there by virtue of the linked issue.

@TimvdLippe
Copy link
Contributor

TimvdLippe commented Jul 30, 2021

Ah of course. Sorry for the noise!

fregante added a commit to eslint-community/eslint-formatter-table that referenced this pull request Aug 3, 2021
@fregante
Copy link
Contributor Author

fregante commented Aug 3, 2021

If anyone wants to maintain these 2 formatters, let me know, they're available as standalone projects:

Please advertise them in your post because I won't be maintaining them.

@nzakas nzakas merged commit 86bb63b into eslint:master Aug 5, 2021
14 checks passed
@fregante fregante deleted the two-less branch Aug 5, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 2, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove some formatters from the core
7 participants