Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix example for require-atomic-updates #14562

merged 1 commit into from May 4, 2021


Copy link

@mdjermanovic mdjermanovic commented May 4, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

result += yield; is an incorrect code for this rule, and it's indeed in examples of incorrect code, but was also in examples of correct code.

I fixed it to result = (yield) + result;

Is there anything you'd like reviewers to focus on?

nzakas approved these changes May 4, 2021
@nzakas nzakas merged commit 6791dec into master May 4, 2021
14 checks passed
@nzakas nzakas deleted the requireatomicupdates-fixexample branch May 4, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants