Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Switch to native Array flat/flatMap #14614

Merged
merged 1 commit into from Aug 14, 2021

Conversation

stephenwade
Copy link
Contributor

@stephenwade stephenwade commented May 22, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Followup to #14287 to remove old syntax.

What changes did you make? (Give an overview)

Replaced old syntax with newer syntax that was not available in Node 10.

Is there anything you'd like reviewers to focus on?

This can be merged after support for Node 10 is dropped.

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label May 22, 2021
@mdjermanovic mdjermanovic added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels May 26, 2021
@stephenwade stephenwade closed this Aug 5, 2021
@stephenwade stephenwade reopened this Aug 5, 2021
@stephenwade stephenwade marked this pull request as ready for review Aug 5, 2021
@bmish bmish changed the title Chore: Replace old syntax for Array flat/flatMap Chore: Switch to native Array flat/flatMap Aug 5, 2021
bmish
bmish approved these changes Aug 5, 2021
Copy link
Member

@btmills btmills left a comment

Thanks!

@btmills btmills merged commit 0c86b68 into eslint:master Aug 14, 2021
13 checks passed
@stephenwade stephenwade deleted the remove-lodash-4 branch Aug 16, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 11, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants