Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: support multiline /*eslint-env*/ directives (fixes #14652) #14660

Merged
merged 3 commits into from Jun 4, 2021

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jun 3, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

update the regexp to allow linebreaks.

Is there anything you'd like reviewers to focus on?

not really.

@aladdin-add aladdin-add added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 3, 2021
@aladdin-add aladdin-add requested a review from mdjermanovic Jun 3, 2021
@mdjermanovic mdjermanovic added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 3, 2021
@mdjermanovic mdjermanovic linked an issue Jun 3, 2021 that may be closed by this pull request
Copy link
Member

@mdjermanovic mdjermanovic left a comment

I think this should be tagged as Update:, as it could enable new globals in an existing code.

For example, this will be a new error:

/* eslint-env browser
*/

/* eslint no-shadow: ["error", { "builtinGlobals": true }] */

window => {}

lib/linter/linter.js Outdated Show resolved Hide resolved
tests/lib/linter/linter.js Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@aladdin-add aladdin-add changed the title Fix: linter ignores multiline /*eslint-env*/ directives (fixes #14652) Update: linter ignores multiline /*eslint-env*/ directives (fixes #14652) Jun 3, 2021
@aladdin-add aladdin-add changed the title Update: linter ignores multiline /*eslint-env*/ directives (fixes #14652) Update: linter ignores multiline /*eslint-env*/ directives(fixes #14652) Jun 3, 2021
@aladdin-add aladdin-add changed the title Update: linter ignores multiline /*eslint-env*/ directives(fixes #14652) Update: multiline /*eslint-env*/ directives (fixes #14652) Jun 3, 2021
@eslint eslint deleted a comment from eslint-github-bot bot Jun 3, 2021
@eslint eslint deleted a comment from eslint-github-bot bot Jun 3, 2021
@aladdin-add aladdin-add changed the title Update: multiline /*eslint-env*/ directives (fixes #14652) Update: support multiline /*eslint-env*/ directives (fixes #14652) Jun 3, 2021
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 4, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit c545163 into eslint:master Jun 4, 2021
14 checks passed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 2, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter ignores multiline /* eslint-env */ directives
2 participants