Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: add some rules to eslint:recommended (refs #14673) #14691

Merged
merged 1 commit into from Aug 5, 2021

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jun 10, 2021

  • no-loss-of-precision
  • no-unsafe-optional-chaining
  • no-useless-backreference
  • no-nonoctal-decimal-escape

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

update eslint:recommended, refs #14673

Is there anything you'd like reviewers to focus on?

* no-loss-of-precision
* no-unsafe-optional-chaining
* no-useless-backreference
* no-nonoctal-decimal-escape
@aladdin-add aladdin-add added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible labels Jun 10, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@nzakas nzakas linked an issue Jun 17, 2021 that may be closed by this pull request
nzakas
nzakas approved these changes Jun 17, 2021
@nzakas nzakas merged commit 8cce06c into eslint:master Aug 5, 2021
13 checks passed
@aladdin-add aladdin-add deleted the issue14673 branch Aug 6, 2021
@atjn atjn mentioned this pull request Dec 1, 2021
2 tasks
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 2, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update eslint:recommended and eslint-config-eslint.
4 participants