Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: improve use-isnan rule to detect Number.NaN (fixes #14715) #14718

Merged
merged 5 commits into from Jun 26, 2021

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jun 18, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix #14715

Updated isNaNIdentifier logic to detect Number.isNaN as well.

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jun 18, 2021
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jun 19, 2021
lib/rules/use-isnan.js Outdated Show resolved Hide resolved
@mdjermanovic mdjermanovic changed the title Update: improve isNaNIdentifier to detect Number.isNaN Update: improve use-isnan rule to detect Number.isNaN Jun 22, 2021
@mdjermanovic mdjermanovic changed the title Update: improve use-isnan rule to detect Number.isNaN Update: improve use-isnan rule to detect Number.NaN Jun 22, 2021
docs/rules/use-isnan.md Outdated Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@snitin315 snitin315 requested a review from mdjermanovic Jun 22, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

nzakas
nzakas approved these changes Jun 26, 2021
@mdjermanovic mdjermanovic changed the title Update: improve use-isnan rule to detect Number.NaN Update: improve use-isnan rule to detect Number.NaN (fixes #14715) Jun 26, 2021
@mdjermanovic mdjermanovic merged commit 104c0b5 into master Jun 26, 2021
14 checks passed
@mdjermanovic mdjermanovic deleted the update-use-isnan branch Jun 26, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 24, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Number.NaN within use-isnan
3 participants