Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: provide more context to no-eq-null #14801

Merged
merged 2 commits into from Jul 15, 2021

Conversation

gfyoung
Copy link
Contributor

@gfyoung gfyoung commented Jul 14, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Encourage use of the more powerful eqeqeq rule for linting equality checks.

  • Indicate this rule is compatible with an analogous rule in JSHint.

xref #179
closes #14749

Is there anything you'd like reviewers to focus on?

N/A

cc @btmills

* Encourage use of the more powerful
eqeqeq rule for linting equality checks.

* Indicate this rule is compatible with
an analogous rule in JSHint.

xref eslint#179
closes eslint#14749
@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jul 14, 2021
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jul 15, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM, thanks!

Copy link
Member

@aladdin-add aladdin-add left a comment

there is a linting issue in the md file. can you fix it please?

Copy link
Member

@btmills btmills left a comment

LGTM as soon as CI passes. Thanks for this improvement @gfyoung!

docs/rules/no-eq-null.md Outdated Show resolved Hide resolved
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
@gfyoung
Copy link
Contributor Author

gfyoung commented Jul 15, 2021

@aladdin-add @btmills: Can you guys take another look?

Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM, thanks for contributing.

@aladdin-add aladdin-add merged commit 39115c8 into eslint:master Jul 15, 2021
14 checks passed
@gfyoung gfyoung deleted the no-eq-null-docs branch Jul 15, 2021
bmish added a commit to bmish/eslint that referenced this pull request Jul 27, 2021
* master:
  Chore: Adopt `eslint-plugin/require-meta-docs-url` rule internally (eslint#14823)
  Docs: New syntax issue template (eslint#14826)
  Chore: assertions on reporting loc in `unicode-bom` (refs eslint#12334) (eslint#14809)
  Docs: fix multiple broken links (eslint#14833)
  Chore: use `actions/setup-node@v2` (eslint#14816)
  Docs: Update README team and sponsors
  7.31.0
  Build: changelog update for 7.31.0
  Upgrade: @eslint/eslintrc to v0.4.3 (eslint#14808)
  Update: add end location to report in `consistent-return` (refs eslint#12334) (eslint#14798)
  Docs: update BUG_REPORT template (eslint#14787)
  Docs: provide more context to no-eq-null (eslint#14801)
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 12, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Possible Deprecation?] no-eq-null (Seems redundant against eqeqeq)
4 participants