Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: reporting loc for never option in eol-last (refs #12334) #14840

Merged
merged 2 commits into from Aug 21, 2021

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jul 27, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Other, please explain:

What changes did you make? (Give an overview)

Refs #12334

Add assertions on reporting location in test cases for eol-last.

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jul 27, 2021
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Jul 27, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

I think it's fine for "always" to report only start loc after the code, but for "never" we could report the linebreak's range (VSCode handles this well by underlining space after the column end) like we are already doing in the linebreak-style rule. Thoughts?

@snitin315
Copy link
Contributor Author

snitin315 commented Aug 2, 2021

Makes sense, I will update 👍🏻

@snitin315 snitin315 changed the title Chore: assertions on reporting loc in eol-last (refs #12334) Update: improve end report location for never option in eol-last (refs #12334) Aug 2, 2021
@eslint-github-bot
Copy link

eslint-github-bot bot commented Aug 2, 2021

Hi @snitin315!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

@snitin315 snitin315 changed the title Update: improve end report location for never option in eol-last (refs #12334) Update: improve reporting loc for never option in eol-last (refs #12334) Aug 2, 2021
@eslint-github-bot
Copy link

eslint-github-bot bot commented Aug 2, 2021

Hi @snitin315!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

@snitin315 snitin315 changed the title Update: improve reporting loc for never option in eol-last (refs #12334) Update: reporting loc for never option in eol-last (refs #12334) Aug 2, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 3d7d5fb into master Aug 21, 2021
14 checks passed
@mdjermanovic mdjermanovic deleted the chore/eol-test-loc branch Aug 21, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 18, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants