Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Simplify internal no-invalid-meta rule #14842

Merged
merged 1 commit into from Jul 29, 2021

Conversation

@bmish
Copy link
Member

@bmish bmish commented Jul 27, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)

A few cases in our internal rule no-invalid-meta can be removed and replaced by:

And we can also enable a few other useful rules:

Follow-up to these other PRs to switch us from custom internal lint rules to public rules:

CC: @aladdin-add

Is there anything you'd like reviewers to focus on?

No.

@bmish bmish force-pushed the simplify-no-invalid-meta branch from 9f348f2 to 8733c21 Jul 27, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM, thanks!

@aladdin-add aladdin-add requested a review from mdjermanovic Jul 28, 2021
nzakas
nzakas approved these changes Jul 29, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM. Thanks

@nzakas nzakas added chore and removed triage labels Jul 29, 2021
@bmish bmish merged commit ed007c8 into eslint:master Jul 29, 2021
14 checks passed
@bmish bmish deleted the simplify-no-invalid-meta branch Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants