Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add v8.0.0 migration guide (fixes #14856) #14884

Merged
merged 10 commits into from Aug 14, 2021
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Aug 5, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Adds the v8.0.0 migration guide.

Is there anything you'd like reviewers to focus on?

Did I miss any breaking changes?

@nzakas nzakas added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 5, 2021
@nzakas nzakas linked an issue Aug 5, 2021 that may be closed by this pull request
docs/user-guide/migrating-to-8.0.0.md Outdated Show resolved Hide resolved
bmish
bmish approved these changes Aug 5, 2021
docs/user-guide/migrating-to-8.0.0.md Show resolved Hide resolved
docs/user-guide/migrating-to-8.0.0.md Show resolved Hide resolved
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
@nzakas
Copy link
Member Author

nzakas commented Aug 11, 2021

TSC Question: do we want to promote eslint-plugin-eslint-plugin in the migration guide?

@nzakas nzakas added the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Aug 11, 2021
nzakas and others added 3 commits Aug 11, 2021
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
Copy link
Member

@btmills btmills left a comment

This looks good! Four inline suggestions, so other than the broken link, take what you'd like.

docs/user-guide/migrating-to-8.0.0.md Outdated Show resolved Hide resolved
docs/user-guide/migrating-to-8.0.0.md Outdated Show resolved Hide resolved
docs/user-guide/migrating-to-8.0.0.md Outdated Show resolved Hide resolved
docs/user-guide/migrating-to-8.0.0.md Outdated Show resolved Hide resolved
nzakas and others added 4 commits Aug 14, 2021
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
@btmills btmills merged commit 28fe19c into master Aug 14, 2021
13 checks passed
@btmills btmills deleted the v8-migration-guide branch Aug 14, 2021
@nzakas nzakas removed the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Aug 26, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 11, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write "Migrating to v8.0.0" guide
6 participants