Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: js-yaml to v4 #14890

Merged
merged 2 commits into from Aug 10, 2021
Merged

Upgrade: js-yaml to v4 #14890

merged 2 commits into from Aug 10, 2021

Conversation

bmish
Copy link
Sponsor Member

@bmish bmish commented Aug 6, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)

Updates dependency.

https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md#400---2021-01-03

Also allow Python licenses (OSI approved) for transitive dependency argparse.

Is there anything you'd like reviewers to focus on?

No.

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 6, 2021
@bmish
Copy link
Sponsor Member Author

bmish commented Aug 6, 2021

It looks like the licensing check failed:

Validating licenses
Python-2.0 license for argparse@2.0.1 is impermissible.

Links for context about argparse/js-yaml (TLDR: this dependency and the license won't be changing):

Context about licensing in eslint:

So we need to decide if the Python license is acceptable. It looks like the Python license is OSI approved: https://opensource.org/licenses/alphabetical

@bmish bmish marked this pull request as ready for review Aug 6, 2021
@nzakas
Copy link
Member

nzakas commented Aug 6, 2021

Let me ask the OpenJS folks

nzakas
nzakas approved these changes Aug 9, 2021
Copy link
Member

@nzakas nzakas left a comment

I believe this is fine.

Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM

@nzakas nzakas merged commit 88db3f5 into eslint:master Aug 10, 2021
13 checks passed
bmish added a commit to bmish/eslint that referenced this pull request Aug 11, 2021
* master:
  Chore: Add rel/abs path tests in `no-restricted-{imports/modules}` rules (eslint#14910)
  Upgrade: Debug 4.0.1 > 4.3.2 (eslint#14892)
  Chore: add assertions on reporting location in `semi` (eslint#14899)
  Fix: no-useless-computed-key edge cases with class fields (refs eslint#14857) (eslint#14903)
  Upgrade: `js-yaml` to v4 (eslint#14890)
  Fix: prefer-destructuring PrivateIdentifier false positive (refs eslint#14857) (eslint#14897)
  Fix: dot-notation false positive with private identifier (refs eslint#14857) (eslint#14898)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Docs: improve rule details for `no-console` (fixes eslint#14793) (eslint#14901)
  Update: check class fields in no-extra-parens (refs eslint#14857) (eslint#14906)
  Docs: add class fields in no-multi-assign documentation (refs eslint#14857) (eslint#14907)
  Docs: add class fields in func-names documentation (refs eslint#14857) (eslint#14908)
  Upgrade: `eslint-visitor-keys` to v3 (eslint#14902)
  Upgrade: `markdownlint` dev dependencies (eslint#14883)
  Upgrade: @humanwhocodes/config-array to 0.6 (eslint#14891)
  Chore: Specify Node 14.x for Verify Files CI job (eslint#14896)
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 7, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants