Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add test assertions on reporting location in semi (refs #12334) #14899

Merged
merged 1 commit into from Aug 10, 2021

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Aug 7, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Other, please explain: Refs #12334

What changes did you make? (Give an overview)

add test assertions on location for semi

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 7, 2021
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Aug 7, 2021
nzakas
nzakas approved these changes Aug 10, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM. Thanks for doing this.

@nzakas nzakas merged commit f984515 into master Aug 10, 2021
13 checks passed
@nzakas nzakas deleted the update/semi-report-loc branch Aug 10, 2021
@bmish bmish changed the title Chore: add assetions on reporting location in semi (refs #12334) Chore: add test assertions on reporting location in semi (refs #12334) Aug 10, 2021
bmish added a commit to bmish/eslint that referenced this pull request Aug 11, 2021
* master:
  Chore: Add rel/abs path tests in `no-restricted-{imports/modules}` rules (eslint#14910)
  Upgrade: Debug 4.0.1 > 4.3.2 (eslint#14892)
  Chore: add assertions on reporting location in `semi` (eslint#14899)
  Fix: no-useless-computed-key edge cases with class fields (refs eslint#14857) (eslint#14903)
  Upgrade: `js-yaml` to v4 (eslint#14890)
  Fix: prefer-destructuring PrivateIdentifier false positive (refs eslint#14857) (eslint#14897)
  Fix: dot-notation false positive with private identifier (refs eslint#14857) (eslint#14898)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Docs: improve rule details for `no-console` (fixes eslint#14793) (eslint#14901)
  Update: check class fields in no-extra-parens (refs eslint#14857) (eslint#14906)
  Docs: add class fields in no-multi-assign documentation (refs eslint#14857) (eslint#14907)
  Docs: add class fields in func-names documentation (refs eslint#14857) (eslint#14908)
  Upgrade: `eslint-visitor-keys` to v3 (eslint#14902)
  Upgrade: `markdownlint` dev dependencies (eslint#14883)
  Upgrade: @humanwhocodes/config-array to 0.6 (eslint#14891)
  Chore: Specify Node 14.x for Verify Files CI job (eslint#14896)
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 7, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants