Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add rel/abs path tests in no-restricted-{imports/modules} rules #14910

Merged

Conversation

@bmish
Copy link
Sponsor Member

@bmish bmish commented Aug 10, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[] Add something to the core
[X] Other, please explain:

Just adding rule tests.

What changes did you make? (Give an overview)

Adds tests to no-restricted-imports and no-restricted-modules rules to cover relative/absolute import paths. It's important to get these test cases into place particularly because the import v5 upgrade breaks some of them. We want test cases in place to document the current behavior and ensure we do not break the current behavior (or if we decide to change the behavior later, we do so explicitly).

Is there anything you'd like reviewers to focus on?

@eslint-github-bot
Copy link

@eslint-github-bot eslint-github-bot bot commented Aug 10, 2021

Hi @bmish!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

@bmish bmish changed the title Chore: Add tests for relative/absolute import paths in no-restricted-imports and no-restricted-modules rules Chore: Add rel/abs path tests in no-restricted-{imports/modules} rules Aug 10, 2021
@eslint-github-bot
Copy link

@eslint-github-bot eslint-github-bot bot commented Aug 10, 2021

Hi @bmish!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

@bmish bmish force-pushed the tests-no-restricted-relative-absolute-paths branch from 06f9c58 to 359abc1 Aug 10, 2021
@bmish bmish mentioned this pull request Aug 10, 2021
1 task
@bmish bmish force-pushed the tests-no-restricted-relative-absolute-paths branch from 359abc1 to 81ff201 Aug 10, 2021
@bmish bmish added the chore label Aug 10, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM! 👍

nzakas
nzakas approved these changes Aug 10, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@nzakas nzakas merged commit 3b6cd89 into eslint:master Aug 11, 2021
13 checks passed
bmish added a commit to bmish/eslint that referenced this issue Aug 11, 2021
* master:
  Chore: Add rel/abs path tests in `no-restricted-{imports/modules}` rules (eslint#14910)
  Upgrade: Debug 4.0.1 > 4.3.2 (eslint#14892)
  Chore: add assertions on reporting location in `semi` (eslint#14899)
  Fix: no-useless-computed-key edge cases with class fields (refs eslint#14857) (eslint#14903)
  Upgrade: `js-yaml` to v4 (eslint#14890)
  Fix: prefer-destructuring PrivateIdentifier false positive (refs eslint#14857) (eslint#14897)
  Fix: dot-notation false positive with private identifier (refs eslint#14857) (eslint#14898)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Docs: improve rule details for `no-console` (fixes eslint#14793) (eslint#14901)
  Update: check class fields in no-extra-parens (refs eslint#14857) (eslint#14906)
  Docs: add class fields in no-multi-assign documentation (refs eslint#14857) (eslint#14907)
  Docs: add class fields in func-names documentation (refs eslint#14857) (eslint#14908)
  Upgrade: `eslint-visitor-keys` to v3 (eslint#14902)
  Upgrade: `markdownlint` dev dependencies (eslint#14883)
  Upgrade: @humanwhocodes/config-array to 0.6 (eslint#14891)
  Chore: Specify Node 14.x for Verify Files CI job (eslint#14896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants