Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle computed class fields in operator-linebreak (refs #14857) #14915

Merged
merged 1 commit into from Aug 12, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 10, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

refs #14857, fixes #14591 (comment)

What changes did you make? (Give an overview)

Updated the operator-linebreak rule to account for ] of computed class fields by finding the operator token by value. Also switched to searching from the right side in order to better handle language extensions (e.g., typescript allows separate type annotation nodes with their own tokens between the left side node and the operator).

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 10, 2021
nzakas
nzakas approved these changes Aug 11, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM

Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM

@nzakas nzakas merged commit af96584 into master Aug 12, 2021
13 checks passed
@nzakas nzakas deleted the operatorlinebreak-classfields branch Aug 12, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 9, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants