Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix Makefile call to linter.getRules() #14932

Merged
merged 1 commit into from Aug 14, 2021
Merged

Conversation

btmills
Copy link
Member

@btmills btmills commented Aug 14, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Fix the release script

What changes did you make? (Give an overview)

The first attempt to release v8.0.0-beta.0 failed when Makefile.js tried to call linter.getRules().

const rules = require(".").linter.getRules();

The linter object was removed in v8.0.0, so we need to create an instance of Linter.

Is there anything you'd like reviewers to focus on?

There's another getRules() call later in the script when it's generating formatter examples, but that's called from CLIEngine, so it should work. At some point we ought to migrate Makefile.js to the ESLint API.

The `linter` object was removed in v8.0.0, so we need to create an
instance of `Linter`.
@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 14, 2021
@btmills btmills merged commit be334f9 into master Aug 14, 2021
13 checks passed
@btmills btmills deleted the makefile-linter branch Aug 14, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 11, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant