Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove Node 16 CI prerelease workaround (refs #14933)

Merged
merged 2 commits into from Oct 26, 2021

Conversation

btmills
Copy link
Member

@btmills btmills commented Aug 15, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Remove CI prerelease workaround

What changes did you make? (Give an overview)

Several dev dependencies have a peer dependency on the local ESLint. Prereleases don't satisfy regular version range constraints, so the new peer dependency resolution algorithm in Node 16 rejects v8.0.0-beta.0 as a valid peer dependency. Until we're done with prereleases, we can use the --force flag to force npm to accept that the prerelease satisfies the peer dependency.

Is there anything you'd like reviewers to focus on?

Once we release v8.0.0 stable, we can merge this PR. When we do, we should also remove --force from the build script in Jenkins.

@btmills btmills added build accepted blocked do not merge labels Aug 15, 2021
@btmills btmills marked this pull request as draft Aug 15, 2021
ghost
ghost approved these changes Sep 8, 2021
@btmills btmills removed blocked do not merge labels Oct 9, 2021
@btmills btmills marked this pull request as ready for review Oct 9, 2021
@btmills btmills force-pushed the revert-14933-node-16-prerelease-peer-dep branch from f762b28 to 6807fe2 Compare Oct 9, 2021
@btmills btmills marked this pull request as draft Oct 9, 2021
@btmills
Copy link
Member Author

btmills commented Oct 9, 2021

We no longer need --force for our circular dependency, but eslint-plugin-jsdoc doesn't include 8.0.0 in its peer dependency range yet, so we need to keep --force for now.

btmills and others added 2 commits Oct 25, 2021
This reverts the change from #14933 now that all peer dependencies are
valid with ESLint v8.0.0.
@btmills btmills force-pushed the revert-14933-node-16-prerelease-peer-dep branch from 6807fe2 to bb11577 Compare Oct 25, 2021
@btmills btmills marked this pull request as ready for review Oct 25, 2021
@btmills
Copy link
Member Author

btmills commented Oct 25, 2021

eslint-plugin-jsdoc@37.0.0 was released with eslint@^8.0.0 in its peerDependencies, so this is now unblocked!

Note to whomever merges this: we can also remove --force from the Jenkins build script.

@btmills btmills requested a review from aladdin-add Oct 26, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM~

@mdjermanovic mdjermanovic changed the title Build: Remove Node 16 CI prerelease workaround (refs #14933) ci: Remove Node 16 CI prerelease workaround (refs #14933) Oct 26, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 67949bd into main Oct 26, 2021
14 checks passed
@mdjermanovic mdjermanovic deleted the revert-14933-node-16-prerelease-peer-dep branch Oct 26, 2021
@mdjermanovic
Copy link
Member

mdjermanovic commented Oct 26, 2021

When we do, we should also remove --force from the build script in Jenkins.

I removed --force from the eslint Release and both data fetches scripts in Jenkins.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants