Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: keyword-spacing private name compat (refs #14857) #14946

Merged
merged 2 commits into from Aug 20, 2021

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Aug 18, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixes incorrect behavior in for-of and for-in when a private identifier is used in the lefthand side.

#14591 (review)

Is there anything you'd like reviewers to focus on?

Did I miss anything?

@nzakas nzakas added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 18, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, I left only a small suggestion about the tests.

tests/lib/rules/keyword-spacing.js Outdated Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@mdjermanovic mdjermanovic merged commit ee1b54f into master Aug 20, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the class-fields-keyword-spacing branch Aug 20, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 17, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants