Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add test for merging parserOptions in Linter #14948

Merged
merged 1 commit into from Aug 23, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 19, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Adds a test for Linter module.

refs #14931 attempt to replace lodash.merge with Object.assign.

What changes did you make? (Give an overview)

Added a simple test that confirms that parserOptions are deeply merged in Linter.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added the chore This change is not user-facing label Aug 19, 2021
@mdjermanovic mdjermanovic mentioned this pull request Aug 19, 2021
1 task
Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM!

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 23, 2021
@mdjermanovic mdjermanovic merged commit 2d18db6 into master Aug 23, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the test-merging-parseroptions branch Aug 23, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 20, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants