Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Enforce jsdoc check-line-alignment (never) #14955

Merged
merged 1 commit into from Aug 24, 2021
Merged

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Aug 21, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Enforce that the components of a jsdoc block (e.g., type, name, description) are never aligned (by being padded with extra whitespace).

Is there anything you'd like reviewers to focus on?

As per #14814 (comment) , this was to be approved if fixers were available, and the jsdoc plugin does provide a fixer here.

@brettz9 brettz9 added the chore This change is not user-facing label Aug 21, 2021
nzakas
nzakas approved these changes Aug 24, 2021
Copy link
Member

@nzakas nzakas left a comment

Looks nice! Thanks.

@brettz9 brettz9 merged commit a79c9f3 into master Aug 24, 2021
13 checks passed
@brettz9 brettz9 deleted the line-align branch Aug 24, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 21, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants