Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update deprecated information #14961

merged 1 commit into from Aug 24, 2021


Copy link

@wafuwafu13 wafuwafu13 commented Aug 22, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Update deprecated information.

Is there anything you'd like reviewers to focus on?

Copy link
Sponsor Member

@bmish bmish commented Aug 22, 2021

Looks reasonable. We should add tests that deprecated rules:

  • Have a This rule was deprecated... notice at the top of their rule doc
  • Have @deprecated in their rule doc comment

I believe Makefile.js is the place where we currently have checks like that.

Copy link
Contributor Author

@wafuwafu13 wafuwafu13 commented Aug 23, 2021

here 👀

target.checkRuleFiles = function() {

Can I add tests in next PR?

nzakas approved these changes Aug 24, 2021
Copy link

@nzakas nzakas left a comment

LGTM. Thanks.

@nzakas nzakas changed the title Docs: Update deprecated information Chore: Update deprecated information Aug 24, 2021
Copy link

@nzakas nzakas commented Aug 24, 2021

@wafuwafu13 yes, you can do that in a separate PR

Copy link

@aladdin-add aladdin-add left a comment

LGTM, thanks!

@aladdin-add aladdin-add merged commit 44f7de5 into eslint:master Aug 24, 2021
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants