Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: support class fields in func-name-matching (refs #14857) #14964

Merged
merged 1 commit into from Aug 24, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 23, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

refs #14857, fixes #14591 (comment)

What changes did you make? (Give an overview)

Updated the func-name-matching rule to:

  • ignore assignments to private fields, such as this.#x = function foo() {};, instead of crashing (this is a bug fix).
  • check and report class field definitions, e.g. class C { foo = function bar() {}; } (this is an enhancement). Private fields are ignored.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 23, 2021
nzakas
nzakas approved these changes Aug 24, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM. I’m unsure if we should include private names or not, but I think it’s fine to roll with this and just see what feedback we get.

Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM! 💯

@mdjermanovic mdjermanovic merged commit 44c6fc8 into master Aug 24, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the funcnamematching-classfields branch Aug 24, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 21, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants