Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: camelcase ignoreGlobals shouldn't apply to undef vars (refs #14857) #14966

Merged
merged 1 commit into from Aug 24, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 23, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

refs #14857, fixes #14591 (comment)

In ESLint v7.32.0, ignoreGlobals option in the camelcase rule doesn't apply to undefined variables.

/* eslint camelcase: ["error", { ignoreGlobals: true }] */

undefined_variable; // error

implicit_global = 1; // error

Online Demo (still v7.32.0)

The refactoring made in #14591 to support class fields accidentally changed this behavior.

What changes did you make? (Give an overview)

Fixed the camelcase rule to restore the v7.32.0 behavior in regard to the ignoreGlobals option and undefined variables, and added missing test cases.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 23, 2021
Copy link
Contributor

@snitin315 snitin315 left a comment

Looks good.

nzakas
nzakas approved these changes Aug 24, 2021
@nzakas nzakas merged commit 3409785 into master Aug 24, 2021
13 checks passed
@nzakas nzakas deleted the camelcase-undefvars branch Aug 24, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 21, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants