Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove docs script (fixes #14288) #14971

Merged
merged 3 commits into from Aug 25, 2021
Merged

Docs: remove docs script (fixes #14288) #14971

merged 3 commits into from Aug 25, 2021

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Aug 24, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add auto fixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Chore

What changes did you make? (Give an overview)

Fixes #14288

remove docs script from package.json, related code, and documentation.

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 24, 2021
@snitin315 snitin315 changed the title Chore: remove docs script (fixes #14288) Docs: remove docs script (fixes #14288) Aug 24, 2021
@nzakas nzakas changed the title Docs: remove docs script (fixes #14288) Chore: remove docs script (fixes #14288) Aug 24, 2021
nzakas
nzakas approved these changes Aug 24, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM

@snitin315 snitin315 changed the title Chore: remove docs script (fixes #14288) Docs: remove docs script (fixes #14288) Aug 24, 2021
@snitin315
Copy link
Contributor Author

snitin315 commented Aug 24, 2021

Updated the PR title with Docs as there is one documentation change.

@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Aug 24, 2021
@@ -81,12 +81,8 @@ Be sure to run this after making changes and before sending a pull request with

#### npm run lint

Runs just the JavaScript and JSON linting on the repository
Runs just the JavaScript and JSON linting on the repository.
Copy link
Member

@aladdin-add aladdin-add Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not related to the PR, but atm it also linting markdown files. 😄

@nzakas nzakas merged commit 6663e7a into master Aug 25, 2021
13 checks passed
@nzakas nzakas deleted the rm-docs-script branch Aug 25, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 22, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running npm run docs get error
3 participants