Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add test that deprecated rules display a deprecated notice #14989

Merged
merged 5 commits into from Aug 31, 2021

Conversation

wafuwafu13
Copy link
Contributor

@wafuwafu13 wafuwafu13 commented Aug 28, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: Add tests

What changes did you make? (Give an overview)

I update deprecated information at #14961 and turned out we need to add some more tests.
#14961 (comment)

Have a This rule was deprecated... notice at the top of their rule doc
Have @deprecated in their rule doc comment

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 28, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 28, 2021

CLA Signed

The committers are authorized under a signed CLA.

@@ -1,5 +1,6 @@
# enforce consistent indentation (indent-legacy)

This rule was **deprecated** in ESLint v4.0.0.
Copy link
Sponsor Member

@bmish bmish Aug 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have blank line after:

Suggested change
This rule was **deprecated** in ESLint v4.0.0.
This rule was **deprecated** in ESLint v4.0.0.

Copy link
Contributor Author

@wafuwafu13 wafuwafu13 Aug 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 48b21c2

Makefile.js Show resolved Hide resolved
@bmish bmish changed the title Chore: Add tests for check deprecated rule Chore: Add test that deprecated rules display a deprecated notice Aug 28, 2021
bmish
bmish approved these changes Aug 29, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM, thanks!

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Aug 31, 2021
Copy link
Contributor

@snitin315 snitin315 left a comment

Looks Good!

@aladdin-add aladdin-add merged commit b4232d4 into eslint:master Aug 31, 2021
14 checks passed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 28, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants