Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Switch issues to use forms #15024

Merged
merged 10 commits into from Sep 7, 2021
Merged

Chore: Switch issues to use forms #15024

merged 10 commits into from Sep 7, 2021

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Sep 3, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Switching some of our issue templates to use forms so we can enforce the information we want.

Is there anything you'd like reviewers to focus on?

How does it look?

@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Sep 3, 2021
@nzakas nzakas marked this pull request as ready for review Sep 3, 2021
@nzakas
Copy link
Member Author

nzakas commented Sep 3, 2021

There's no easy way to preview these forms at the moment, so starting with the one that gets used the least as a test case.

@nzakas nzakas marked this pull request as draft Sep 3, 2021
@nzakas
Copy link
Member Author

nzakas commented Sep 3, 2021

Ah, the preview wasn't showing due to a conflict with the title. I've fixed that, so now you can view each file and see a preview of what the issue will look like.

@nzakas nzakas marked this pull request as ready for review Sep 3, 2021
Copy link
Contributor

@snitin315 snitin315 left a comment

Nice change.

@snitin315
Copy link
Contributor

snitin315 commented Sep 4, 2021

Quick link to see previews

@aladdin-add
Copy link
Member

aladdin-add commented Sep 4, 2021

👍 looks much better! why not also convert the new-syntax template?

Copy link
Member

@btmills btmills left a comment

These forms are neat! I had a few ideas, so take what you like.

.github/ISSUE_TEMPLATE/bug-report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/change.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/new-rule.yml Outdated Show resolved Hide resolved
nzakas and others added 3 commits Sep 7, 2021
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
@nzakas
Copy link
Member Author

nzakas commented Sep 7, 2021

@aladdin-add I couldn’t figure out what to do about the checklist for the new syntax template, as that is the only issue template we have with subtasks. Rather than blocking on that, I thought I’d get the others done and study a bit more to figure out the right way to convert that last template.

btmills
btmills approved these changes Sep 7, 2021
@aladdin-add aladdin-add merged commit 143a598 into master Sep 7, 2021
13 checks passed
@aladdin-add aladdin-add deleted the issue-template-forms branch Sep 7, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 7, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants