Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix failing cli test #15041

Merged
merged 1 commit into from Sep 9, 2021
Merged

Chore: fix failing cli test #15041

merged 1 commit into from Sep 9, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Sep 8, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

One of the tests expects that null.something throws error with a certain message, but that message has been sligthly changed in the latest Node 16 and thus the test fails:

https://github.com/eslint/eslint/pull/15039/checks?check_run_id=3549061940

What changes did you make? (Give an overview)

Fixed the test to not rely on v8 error messages.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added the chore This change is not user-facing label Sep 8, 2021
@mdjermanovic mdjermanovic merged commit 921ba1e into master Sep 9, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the fix-cli-test branch Sep 9, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 9, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants