Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: semicolon-less style in lines-between-class-members (refs #14857) #15045

Merged
merged 1 commit into from Sep 10, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Sep 9, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

refs #14857, fixes #14591 (comment)

What changes did you make? (Give an overview)

Fixed the lines-between-class-members to support semicolon-less style.

For example:

/* eslint lines-between-class-members: ["error", "always"]*/

class C {
  a // this is ok, although this field technically ends with the `;` below
  
  ;b

  c // this isn't ok either way, but the linebreak will be inserted here, not after `;`
  ;d
}

This matches the logic in padding-line-between-statements (Demo)

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Sep 9, 2021
nzakas
nzakas approved these changes Sep 10, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM

@mdjermanovic mdjermanovic merged commit 9bd3d87 into master Sep 10, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the linesbetweenclassmembers-classfields branch Sep 10, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 10, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants