Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Disallow reserved words in ES3 (fixes #15017) #15046

Merged
merged 2 commits into from Sep 10, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Sep 10, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

fixes #15017

Disallows use of reserved words as identifiers when default parser is used with "ecmaVersion": 3.

This is a breaking change.

What changes did you make? (Give an overview)

Updated espree to v9.0.0 in package.json.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible labels Sep 10, 2021
@mdjermanovic mdjermanovic marked this pull request as ready for review Sep 10, 2021
@mdjermanovic mdjermanovic merged commit 7cf96cf into master Sep 10, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the espree-9.0.0 branch Sep 10, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 10, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES3 reserved words
1 participant