Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: test Property > .key with { a = 1 } pattern (fixes #14799) #15072

Merged
merged 1 commit into from Sep 16, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Sep 16, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

closes #14799

What changes did you make? (Give an overview)

Added a test to confirm that #14799 has been fixed in ESLint 8 (by upgrading espree -> acorn).

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added the chore This change is not user-facing label Sep 16, 2021
nzakas
nzakas approved these changes Sep 16, 2021
@nzakas nzakas merged commit 47be800 into master Sep 16, 2021
13 checks passed
@nzakas nzakas deleted the issue14799 branch Sep 16, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 16, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selector Property > .key can't match key in const {a = 1} = b;
2 participants