Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Suggest missing rule in flat config (fixes #14027) #15074

Merged
merged 3 commits into from Sep 24, 2021

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Sep 16, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This implements a search in flat config when a rule ID isn't found. It searches through other plugins to see if there's a rule name matching the one specified.

Is there anything you'd like reviewers to focus on?

Do the changes work as expected?

@nzakas nzakas added enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Sep 16, 2021
@nzakas
Copy link
Member Author

nzakas commented Sep 24, 2021

Updated. As mentioned previously, I'll do a round of UX improvements later around the @ plugin.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 67c0074 into master Sep 24, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the issue14027 branch Sep 24, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 24, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a specific error for a rule specification missing a plugin prefix
2 participants