Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: space-before-blocks ignore after switch colons (fixes #15082) #15093

Merged
merged 2 commits into from Sep 24, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Sep 22, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #15082

What changes did you make? (Give an overview)

Updated space-before-blocks to ignore spacing after switch case colons, because that conflicts with switch-colon-spacing.

Is there anything you'd like reviewers to focus on?

I marked this as "Update" although this change can produce only fewer warnings, because it changes the functionality of this rule while this wasn't a bug in the rule itself.

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Sep 22, 2021
nzakas
nzakas approved these changes Sep 23, 2021
@mdjermanovic mdjermanovic merged commit cf34e5c into master Sep 24, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the issue15082 branch Sep 24, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 24, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: conflict between space-before-blocks and switch-colon-spacing
2 participants