Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: require-atomic-updates property assignment message (fixes #15076) #15109

Merged
merged 1 commit into from Oct 9, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Sep 27, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #15076 (fixes invalid error message; possible false positive is being discussed in #11899)

What changes did you make? (Give an overview)

In the original code from #15076:

'use strict';

const opts = {}; // stubbed for repro
const run = () => Promise.resolve({ exit_code: 0 }); // stubbed for repro

(async () => {
  if (opts._.length) {
    if (opts._[0] === '-') {
      opts.spec = process.stdin;
    } else {
      opts.spec = opts._;
    }
  }
  delete opts._;
  try {
    const { exit_code } = await run(opts);
    process.exitCode = exit_code;
  } catch (e) {
    console.error(e.stack);
    process.exitCode = 1;
  }
})();

instead of:

Possible race condition: `process.exitCode` might be reassigned based on an outdated value of `process.exitCode`  require-atomic-updates

the error message will be:

Possible race condition: `process.exitCode` might be assigned based on an outdated state of `process`  require-atomic-updates

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug rule accepted labels Sep 27, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM~

Copy link
Contributor

@snitin315 snitin315 left a comment

LGTM

btmills
btmills approved these changes Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age bug rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants